used go:embed with crpd

templates/crpd/juniper.conf → nodes/crpd/crpd.cfg

@@ -1,4 +1,3 @@
-## Last changed: 2021-01-11 09:07:59 UTC
 version 20200609.165031.6_builder.r1115480;
 system {
     root-authentication {

nodes/crpd/crpd.go

@@ -6,6 +6,7 @@ package crpd
 
 import (
 	"context"
+	_ "embed"
 	"fmt"
 	"path"
 
@@ -16,6 +17,14 @@ import (
 	"github.com/srl-labs/containerlab/utils"
 )
 
+var (
+	//go:embed crpd.cfg
+	cfgTemplate string
+
+	//go:embed sshd_config
+	sshdCfg string
+)
+
 func init() {
 	nodes.Register(nodes.NodeKindCRPD, func() nodes.Node {
 		return new(crpd)
@@ -82,23 +91,22 @@ func createCRPDFiles(nodeCfg *types.NodeConfig) error {
 	// copy crpd config from default template or user-provided conf file
 	cfg := path.Join(nodeCfg.LabDir, "/config/juniper.conf")
 
-	err := nodeCfg.GenerateConfig(cfg, nodes.DefaultConfigTemplates[nodeCfg.Kind])
+	err := nodeCfg.GenerateConfig(cfg, cfgTemplate)
 	if err != nil {
 		log.Errorf("node=%s, failed to generate config: %v", nodeCfg.ShortName, err)
 	}
 
-	// copy crpd sshd conf file to crpd node dir
-	src := "/etc/containerlab/templates/crpd/sshd_config"
+	// write crpd sshd conf file to crpd node dir
 	dst := path.Join(nodeCfg.LabDir, "/config/sshd_config")
-	err = utils.CopyFile(src, dst)
+	err = utils.CreateFile(dst, sshdCfg)
 	if err != nil {
-		return fmt.Errorf("file copy [src %s -> dst %s] failed %v", src, dst, err)
+		return fmt.Errorf("failed to write sshd_config file %v", err)
 	}
-	log.Debugf("CopyFile src %s -> dst %s succeeded\n", src, dst)
+	log.Debug("Writing sshd_config succeeded")
 
 	if nodeCfg.License != "" {
 		// copy license file to node specific lab directory
-		src = nodeCfg.License
+		src := nodeCfg.License
 		dst = path.Join(nodeCfg.LabDir, "/config/license.conf")
 		if err = utils.CopyFile(src, dst); err != nil {
 			return fmt.Errorf("file copy [src %s -> dst %s] failed %v", src, dst, err)

utils/file.go

@@ -74,17 +74,20 @@ func CopyFileContents(src, dst string) (err error) {
 	return
 }
 
-func CreateFile(file, content string) {
+// CreateFile writes content to a file by path `file`
+func CreateFile(file, content string) error {
 	var f *os.File
 	f, err := os.Create(file)
 	if err != nil {
-		panic(err)
+		return err
 	}
 	defer f.Close()
 
 	if _, err := f.WriteString(content + "\n"); err != nil {
-		panic(err)
+		return err
 	}
+
+	return nil
 }
 
 // CreateDirectory creates a directory by a path with a mode/permission specified by perm.