unexport local methods

srl-labs · Jun 1, 2023 · 4de4d11 · 4de4d11
1 parent 552461d
commit 4de4d11
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/nodes/srl/srl.go b/nodes/srl/srl.go
@@ -110,7 +110,7 @@ var (
 			Funcs(gomplate.CreateFuncs(context.Background(), new(data.Data))).
 			Parse(srlConfigCmdsTpl)
 
-	SRLRequiredKernelVersion = &utils.KernelVersion{
+	requiredKernelVersion = &utils.KernelVersion{
 		Major:    4,
 		Minor:    10,
 		Revision: 0,
@@ -381,8 +381,8 @@ func (s *srl) checkKernelVersion() error {
 	}
 
 	// do the comparison
-	if !kv.GreaterOrEqual(SRLRequiredKernelVersion) {
-		log.Infof("Nokia SR Linux v23.3.1+ requires a kernel version greater than %s. Detected kernel version: %s", SRLRequiredKernelVersion, kv)
+	if !kv.GreaterOrEqual(requiredKernelVersion) {
+		log.Infof("Nokia SR Linux v23.3.1+ requires a kernel version greater than %s. Detected kernel version: %s", requiredKernelVersion, kv)
 	}
 	return nil
 }

diff --git a/utils/kernel_module.go b/utils/kernel_module.go
@@ -29,6 +29,7 @@ func IsKernelModuleLoaded(name string) (bool, error) {
 
 const kernelOSReleasePath = "/proc/sys/kernel/osrelease"
 
+// GetKernelVersion returns the parsed OS kernel version.
 func GetKernelVersion() (*KernelVersion, error) {
 	ver, err := os.ReadFile(kernelOSReleasePath)
 	if err != nil {
@@ -37,7 +38,7 @@ func GetKernelVersion() (*KernelVersion, error) {
 
 	log.Debugf("kernel version: %s", string(ver))
 
-	return ParseKernelVersion(ver)
+	return parseKernelVersion(ver)
 }
 
 // KernelVersion holds the parsed OS kernel version.
@@ -48,7 +49,7 @@ type KernelVersion struct {
 	Remainder string // the rest of the version string, e.g. "-amd64"
 }
 
-func ParseKernelVersion(v []byte) (*KernelVersion, error) {
+func parseKernelVersion(v []byte) (*KernelVersion, error) {
 
 	re := regexp.MustCompile(`(?P<Major>\d+)\.(?P<Minor>\d+)\.(?P<Revision>\d+)(?P<Remainder>\S+)`)