update dependencyManager fake node processing

srl-labs · Jul 26, 2023 · 70c509a · 70c509a
1 parent 4c85c48
commit 70c509a
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/clab/clab.go b/clab/clab.go
@@ -501,12 +501,10 @@ func (c *CLab) CreateLinks(ctx context.Context, workers uint, dm dependency_mana
 
 			var waitNodes []string
 			for _, n := range []*types.NodeConfig{li.A.Node, li.B.Node} {
-				// we should not wait for "host", "mgmt-net" and "macvlan" fake nodes
-				// as they are never managed by dependency manager (never really get created)
-				if n.Kind == "host" || n.ShortName == "mgmt-net" || n.Kind == "macvlan" {
-					continue
+				// we should not wait for "host" fake node or mgmt-net node
+				if n.Kind != "host" && n.ShortName != "mgmt-net" && n.ShortName != "macvlan" {
+					waitNodes = append(waitNodes, n.ShortName)
 				}
-				waitNodes = append(waitNodes, n.ShortName)
 			}
 
 			err := dm.WaitForNodes(waitNodes, dependency_manager.NodeStateCreated)