Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for ip-range definition on docker mgmt net #1365

Merged
merged 5 commits into from
May 8, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented May 4, 2023

As mentioned in #1364 this PR will enable ip-range assignments for docker networks.

mgmt:
  network: lab-mgmt
  bridge: testbr
  ipv4-subnet: 192.168.100.0/24
  ipv4-gw: 192.168.100.1
  ipv4-range: 192.168.100.128/25

@steiler
Copy link
Collaborator Author

steiler commented May 4, 2023

I should mention that I also adjusted the ipv{4,6}_subnet to ipv{4,6}-subnet to allign with ipv{4,6}-gw, which already uses the dash notation.

@steiler steiler marked this pull request as ready for review May 4, 2023 13:29
@hellt hellt added the breaking change PRs that introduce breaking changes label May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1365 (eaeae1c) into main (78a838d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
- Coverage   20.85%   20.82%   -0.03%     
==========================================
  Files          57       57              
  Lines        6278     6286       +8     
==========================================
  Hits         1309     1309              
- Misses       4848     4856       +8     
  Partials      121      121              
Impacted Files Coverage Δ
runtime/docker/docker.go 0.14% <0.00%> (-0.01%) ⬇️
types/types.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PRs that introduce breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants