Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for d-in-d containerlab #1872

Closed
hellt opened this issue Feb 9, 2024 · 5 comments
Closed

Dockerfile for d-in-d containerlab #1872

hellt opened this issue Feb 9, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@hellt
Copy link
Member

hellt commented Feb 9, 2024

Containerlab can successfully run in a d-in-d container and it is a perfect wrapping for CI tasks.

We need to create and publish a d-in-d image that would have a matching release of containerlab installed inside.

Take clabernetes launcher dockerfile and strip it off of extra c9s stuff - https://github.com/srl-labs/clabernetes/blob/main/build/launcher.Dockerfile

@hellt hellt added the enhancement New feature or request label Feb 9, 2024
@robertvolkmann
Copy link
Contributor

@hellt I could work on it. Please assign me, if it make sense.

@hellt
Copy link
Member Author

hellt commented May 7, 2024

Thanks @robertvolkmann
Appreciate the help

@FloSch62
Copy link
Member

Hi,

As it has been quite quiet here, I tried something myself: https://github.com/FloSch62/clab-dind

So far, I have tested it with SRL and SROS, and it works. I had significant problems with cgroups2 and overlay2, but the current version works. Do you have any suggestions for improvement? I still want to test some things, but I wanted to share what I have.

@FloSch62
Copy link
Member

Actually my repo is not "really" needed. With a little bit overhead the devcontainer for containerlab is already providing all it needs.

docker run -it --privileged --cgroupns=host ghcr.io/srl-labs/containerlab/clab-devcontainer:latest /bin/bash -c "sudo dockerd > /dev/null 2>&1 & bash"

should also work in any ci/cd action/pipeline

@hellt
Copy link
Member Author

hellt commented Aug 13, 2024

will close this for now. We can return to this if the existing clab-devcontainer image shows any deficiencies

@hellt hellt closed this as completed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants