Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cRPD 23.1+ version specific changes #2013

Closed
mzagozen opened this issue Apr 24, 2024 · 2 comments
Closed

cRPD 23.1+ version specific changes #2013

mzagozen opened this issue Apr 24, 2024 · 2 comments

Comments

@mzagozen
Copy link
Contributor

I made two changes in the pre-deploy steps for cRPD version 23.1 and newer:

  1. The license file is no longer expected in /config/license/safenet/junos_sfnt.lic, but rather in the parent directory. So it becomes just /config/license/junos_sfnt.lic.
  2. It is no longer required to edit the /etc/sshd_config directly and restart SSHD. The startup config for enabling SSH server and allowing root login are honored when the control plane starts.

Implementing this is straightforward, but I am having trouble coming up with a way of keeping backwards compatibility by conditioning behavior on the version. The current cRPD version is available the container image in /etc/junos/release.txt as a string on a single line. But reading this file requires a running container, so not available yet in the pre-deploy stage. Starting a (separate) container just to read the file and grab the would work, but feels very hacky ... WDYT?

@hellt
Copy link
Member

hellt commented Apr 24, 2024

Regarding the license, it seems it should be possible to use the cli command (#1350) to load one.
Maybe this is version-agnostic enough to work with pre 23 and post 23 versions?

@hellt
Copy link
Member

hellt commented Apr 25, 2024

done in #2014

@hellt hellt closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants