Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use CLI command to load cRPD license #2014

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

mzagozen
Copy link
Contributor

The expected license file location was changed in Junos 22 and later. To keep the code backwards and forwards compatible we use the CLI command to add a license file from a stable location.

Closes #1350

mzagozen and others added 2 commits April 24, 2024 20:16
The expected license file location was changed in Junos 22 and later. To
keep the code backwards and forwards compatible we use the CLI command
to add a license file from a stable location.
@hellt
Copy link
Member

hellt commented Apr 24, 2024

thanks @mzagozen
this lgtm
I presume you tried it with the crpd 23+? I think in general containerlab strives to support the latest releases, to go in a lockstep with the current NOS offerings; with that in mind I think what is important is that newer version runs smoothly, and older ones might be less prioritized in terms of the support

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 53.72%. Comparing base (c5896ac) to head (5bdf63e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
- Coverage   53.77%   53.72%   -0.06%     
==========================================
  Files         160      160              
  Lines       11504    11515      +11     
==========================================
  Hits         6186     6186              
- Misses       4452     4463      +11     
  Partials      866      866              
Files Coverage Δ
nodes/crpd/crpd.go 1.19% <0.00%> (-0.18%) ⬇️

@mzagozen
Copy link
Contributor Author

Right, I only have 23.4R1.9 available for testing. I remember using the CLI command way back anyway :)
Like I mentioned in #2013, the SSH config massaging code is now unnecessary, But I guess since it does not interfere with the current latest it may as well remain in place for older versions.

@hellt hellt merged commit 387114e into srl-labs:main Apr 25, 2024
62 of 63 checks passed
@mzagozen mzagozen deleted the 1350-crpd-load-license branch May 27, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change license provisioning for crpd
2 participants