Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user defined mounts for kinds and nodes #124

Merged
merged 4 commits into from
Nov 16, 2020
Merged

allow user defined mounts for kinds and nodes #124

merged 4 commits into from
Nov 16, 2020

Conversation

hellt
Copy link
Member

@hellt hellt commented Nov 13, 2020

closes #88

this PR allows users to define Bind Mounts for nodes or kinds. For example:

topology:
  kinds:
    srl:
      type: ixr6
      image: srlinux
      license: license.key
      binds:
        - "/tmp/1test:/tmp/bla:ro"

or

topology:
  nodes:
    srl:
      kind: srl
      binds:
        - "/tmp/1test:/tmp/bla"

The format of bindmount string follows the format of docker/oci.

@hellt hellt marked this pull request as ready for review November 13, 2020 17:37
@hellt hellt requested a review from karimra November 13, 2020 17:40
clab/config.go Outdated Show resolved Hide resolved
clab/config.go Outdated Show resolved Hide resolved
@karimra
Copy link
Member

karimra commented Nov 16, 2020

lgtm

@hellt
Copy link
Member Author

hellt commented Nov 16, 2020

merging
docs will be added in #119

@hellt hellt merged commit 422db97 into master Nov 16, 2020
@hellt hellt deleted the bind-mounts branch November 19, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind mount directories should be possible to set per kind and node
2 participants