Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store information about NodeGeneration in registry. #1347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Apr 28, 2023

So far generate.go contained two lists indenpendent from the nodes, that would describe nodes that (1) can be generated and (b) what the interface naming convention would be for the node kind. This will introduce seperate fields in the NodeRegistry for this information, such that the information for this sort of node generation can be defined as part of the node definition

@steiler
Copy link
Collaborator Author

steiler commented Apr 28, 2023

I have, by the way, taken over the actual view on which nodes are eligable for topology generation.
But I have the feeling, that this list could be extended, Maybe take another look at it @hellt

So far generate.go contained two lists indenpendent from the nodes, that would describe nodes that (1) can be generated and (b) what the interface naming convention would be for the node kind. This will introduce seperate fields in the NodeRegistry for this information, such that the information for this sort of node generation can be defined as part of the node definition
@steiler
Copy link
Collaborator Author

steiler commented May 2, 2023

takes also already vr-vsrx into account.

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1347 (dc33e4a) into main (26b2ee4) will increase coverage by 0.19%.
The diff coverage is 86.53%.

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   20.86%   21.05%   +0.19%     
==========================================
  Files          57       57              
  Lines        6275     6280       +5     
==========================================
+ Hits         1309     1322      +13     
+ Misses       4845     4837       -8     
  Partials      121      121              
Impacted Files Coverage Δ
clab/config/utils.go 42.43% <0.00%> (ø)
cmd/generate.go 37.15% <68.42%> (+5.23%) ⬆️
clab/clab.go 31.02% <100.00%> (ø)
clab/register.go 100.00% <100.00%> (ø)

@steiler steiler added the enhancement New feature or request label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant