Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the DOCKER-USER rule deletion #1361

Merged
merged 1 commit into from
May 4, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented May 4, 2023

fixing #1355

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #1361 (78a838d) into main (a3f9ad3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
- Coverage   20.86%   20.85%   -0.01%     
==========================================
  Files          57       57              
  Lines        6275     6278       +3     
==========================================
  Hits         1309     1309              
- Misses       4845     4848       +3     
  Partials      121      121              
Impacted Files Coverage Δ
runtime/docker/docker.go 0.14% <0.00%> (-0.01%) ⬇️

@hellt
Copy link
Member

hellt commented May 4, 2023

strangely I don't understand why I had stale bridges since current 0.40 version removes the rules just fine...
Something to keep an eye on.

This change though makes sense as well, so merging it.

@hellt hellt merged commit 9dc8376 into srl-labs:main May 4, 2023
17 of 18 checks passed
@steiler
Copy link
Collaborator Author

steiler commented May 11, 2023

This will also resolve the following Warnings.
These happen, since we're pointing to the wrong bridge.

WARN[0000] failed to enable LLDP on docker bridge: open /sys/class/net/br-ecdc59977784/bridge/group_fwd_mask: no such file or directory 
WARN[0000] failed to disable TX checksum offloading for the br-ecdc59977784 bridge interface: no such device

Will be fixed in v0.41.0 since it is already merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants