Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements function to check for loaded kernel modules & try auto-load #1363

Merged
merged 8 commits into from
May 9, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented May 4, 2023

implements #1360

@steiler steiler marked this pull request as ready for review May 4, 2023 13:59
@steiler
Copy link
Collaborator Author

steiler commented May 8, 2023

now auto loading the required modules, which is ip_tables and ip6_tables for now.

@steiler
Copy link
Collaborator Author

steiler commented May 8, 2023

also resolves #1329

@steiler steiler changed the title implements function to check for loaded kernel modules implements function to check for loaded kernel modules & try auto-load May 8, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #1363 (23967f0) into main (a3f9ad3) will decrease coverage by 0.05%.
The diff coverage is 19.04%.

@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
- Coverage   20.86%   20.81%   -0.05%     
==========================================
  Files          57       58       +1     
  Lines        6275     6328      +53     
==========================================
+ Hits         1309     1317       +8     
- Misses       4845     4889      +44     
- Partials      121      122       +1     
Impacted Files Coverage Δ
clab/config.go 47.11% <0.00%> (-2.89%) ⬇️
cmd/deploy.go 6.89% <0.00%> (-0.10%) ⬇️
utils/kernel_module.go 72.72% <72.72%> (ø)

... and 2 files with indirect coverage changes

@hellt
Copy link
Member

hellt commented May 9, 2023

Thanks @steiler!

@hellt hellt merged commit 076187b into srl-labs:main May 9, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants