Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for zero length partial config #1423

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jun 7, 2023

If in the course of building a lab, you want to already point to a partial config, which is being filled later on, probably with the use of the lab itself (configuring single node via cli and adapting to other nodes ...) This will prevent the call to scrapligo and return a nil error instead of right now resulting in a panic.
Which in both cases makes the deployment fail.

@steiler
Copy link
Collaborator Author

steiler commented Jun 7, 2023

handling #1422

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #1423 (4894a9c) into main (06505dc) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
+ Coverage   20.32%   20.63%   +0.30%     
==========================================
  Files          58       58              
  Lines        6488     6527      +39     
==========================================
+ Hits         1319     1347      +28     
- Misses       5046     5057      +11     
  Partials      123      123              

see 2 files with indirect coverage changes

@hellt hellt merged commit aa874ca into srl-labs:main Jun 8, 2023
19 checks passed
steiler added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants