Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New link structs from raw #1475

Merged
merged 130 commits into from
Aug 14, 2023
Merged

New link structs from raw #1475

merged 130 commits into from
Aug 14, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jul 20, 2023

the new link struct was just the first step.
Here we're continuing the refactoring.

@steiler steiler mentioned this pull request Aug 3, 2023
@steiler steiler added the enhancement New feature or request label Aug 14, 2023
@steiler
Copy link
Collaborator Author

steiler commented Aug 14, 2023

@hellt alright, so to me this looks good

clab/config_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #1475 (9aa124c) into main (ba86eca) will increase coverage by 0.14%.
The diff coverage is 28.31%.

@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   20.25%   20.40%   +0.14%     
==========================================
  Files          71       79       +8     
  Lines        7634     8269     +635     
==========================================
+ Hits         1546     1687     +141     
- Misses       5952     6443     +491     
- Partials      136      139       +3     
Files Changed Coverage Δ
clab/config/utils.go 44.84% <ø> (+2.40%) ⬆️
clab/graph.go 0.00% <0.00%> (ø)
cmd/deploy.go 6.61% <0.00%> (-0.12%) ⬇️
cmd/destroy.go 7.28% <0.00%> (-0.58%) ⬇️
cmd/exec.go 6.09% <0.00%> (-0.32%) ⬇️
cmd/generate.go 30.76% <0.00%> (-0.57%) ⬇️
cmd/graph.go 16.66% <0.00%> (-1.32%) ⬇️
cmd/save.go 8.88% <0.00%> (-0.87%) ⬇️
cmd/tools_veth.go 6.89% <0.00%> (-0.66%) ⬇️
links/endpoint_bridge.go 0.00% <0.00%> (ø)
... and 19 more

@hellt hellt merged commit 0b023dc into srl-labs:main Aug 14, 2023
17 checks passed
hellt added a commit that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants