-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix openvswitch port assignment #1534
Conversation
waiting for patrick to double check the build |
when creating a lab, the ovsp port is created and added in the selected ovs bridge. That's good if creating a lab that references a bridge that has not manually been created with ovs-vsctl, clab throws an error. But this is not a change in behaviour. ok when destroying a lab, ovsp ports get deleted but their interface is not removed from the ovs bridge. Not a change in behaviour but it would be nice to fix that some day. it is impossible to set the bridge to protocols=OpenFlow13 before launching clab. We can set the protocol version after clab setting a default drop flow and then adding flows to patch likns together works as expected So other than a few changes I'd like fixed, I'd say that this PR fixes the initial bug that I raised and behaviour is back to normal. |
using This can be tested by setting the bridge mode: |
Codecov Report
@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
- Coverage 47.93% 47.75% -0.18%
==========================================
Files 131 131
Lines 12622 12620 -2
==========================================
- Hits 6050 6027 -23
- Misses 5837 5860 +23
+ Partials 735 733 -2
|
fix #1533