Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count clab intfs at the right time #1547

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Count clab intfs at the right time #1547

merged 1 commit into from
Aug 21, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Aug 21, 2023

In 0.43+ the clab_intfs were not counted, as the enpodints were empty.
Moved this after links are resolved.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1547 (1fda72c) into main (3268306) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1547   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files         131      131           
  Lines       12621    12621           
=======================================
  Hits         6028     6028           
  Misses       5860     5860           
  Partials      733      733           
Files Changed Coverage Δ
clab/config.go 65.58% <100.00%> (-0.18%) ⬇️
cmd/deploy.go 67.71% <100.00%> (+0.22%) ⬆️

@hellt hellt merged commit ec16490 into main Aug 21, 2023
19 checks passed
@hellt hellt deleted the clab-intfs branch August 21, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant