Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement link filtering #1549

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Implement link filtering #1549

merged 7 commits into from
Aug 22, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Aug 21, 2023

fix #1546

  • add tests

@hellt hellt marked this pull request as ready for review August 22, 2023 09:11
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1549 (c65e0a6) into main (ec16490) will increase coverage by 0.80%.
The diff coverage is 65.30%.

❗ Current head c65e0a6 differs from pull request most recent head b4f7f93. Consider uploading reports for the commit b4f7f93 to get more accurate results

@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   47.85%   48.66%   +0.80%     
==========================================
  Files         131      132       +1     
  Lines       12621    12665      +44     
==========================================
+ Hits         6040     6163     +123     
+ Misses       5852     5801      -51     
+ Partials      729      701      -28     
Files Changed Coverage Δ
links/link_macvlan.go 10.29% <0.00%> (-0.40%) ⬇️
links/link_host.go 61.53% <42.85%> (-0.97%) ⬇️
links/link_mgmt-net.go 65.11% <42.85%> (-1.96%) ⬇️
clab/clab.go 77.65% <100.00%> (+0.30%) ⬆️
links/link.go 61.61% <100.00%> (+2.04%) ⬆️
links/link_brief.go 79.16% <100.00%> (ø)
links/link_veth.go 77.27% <100.00%> (+1.08%) ⬆️
runtime/podman/util.go 77.77% <100.00%> (-0.73%) ⬇️

... and 8 files with indirect coverage changes

@hellt hellt merged commit b03c1fc into main Aug 22, 2023
5 of 6 checks passed
@hellt hellt deleted the node-filter-fix branch August 22, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node filter issue
1 participant