Allow 1 to 2 digits for the day of month in certificate dates #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal-ca lab CA
Validity
Not Before: Aug 31 12:16:02 2023 GMT
Not After : Sep 1 13:16:02 2023 GMT
hellt
approved these changes
Aug 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
- Coverage 48.62% 48.58% -0.04%
==========================================
Files 132 132
Lines 12688 12689 +1
==========================================
- Hits 6169 6165 -4
- Misses 5818 5822 +4
- Partials 701 702 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are broken, since in the regex that checks the validity dates of certificates, we expect the day of the month to be a 2 digit number. actual it must be {1,2} as visible here with also one or two whitespaces (simplified this to +)