Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Link MTU #1583

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Default Link MTU #1583

merged 7 commits into from
Sep 20, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Sep 8, 2023

Fixing #1580

@steiler steiler requested a review from hellt September 8, 2023 12:21
@steiler steiler added the bug Something isn't working label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1583 (04cefaf) into main (90aa6e0) will increase coverage by 0.00%.
Report is 9 commits behind head on main.
The diff coverage is 89.83%.

❗ Current head 04cefaf differs from pull request most recent head 06121aa. Consider uploading reports for the commit 06121aa to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1583   +/-   ##
=======================================
  Coverage   48.58%   48.59%           
=======================================
  Files         133      133           
  Lines       12773    12789   +16     
=======================================
+ Hits         6206     6215    +9     
- Misses       5863     5870    +7     
  Partials      704      704           
Files Changed Coverage Δ
clab/config.go 66.91% <ø> (ø)
cmd/tools_veth.go 68.10% <ø> (ø)
links/link_macvlan.go 9.92% <71.42%> (-0.29%) ⬇️
links/link_host.go 67.50% <87.50%> (+5.47%) ⬆️
links/link.go 61.61% <100.00%> (ø)
links/link_mgmt-net.go 67.03% <100.00%> (+1.91%) ⬆️
links/link_veth.go 80.90% <100.00%> (ø)

... and 3 files with indirect coverage changes

@hellt hellt merged commit f2b4a62 into srl-labs:main Sep 20, 2023
17 checks passed
@hellt
Copy link
Member

hellt commented Sep 20, 2023

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants