Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate config.json if template is empty #1585

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Sep 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1585 (b76bd9a) into main (90aa6e0) will decrease coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   48.58%   48.55%   -0.04%     
==========================================
  Files         133      133              
  Lines       12773    12778       +5     
==========================================
- Hits         6206     6204       -2     
- Misses       5863     5870       +7     
  Partials      704      704              
Files Changed Coverage Δ
nodes/srl/srl.go 57.07% <0.00%> (-0.65%) ⬇️

... and 1 file with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=srl-labs).

@hellt hellt merged commit d3dd10b into main Sep 12, 2023
18 of 19 checks passed
@hellt hellt deleted the fix-generate-cfg-logic-srl branch September 12, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant