Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in the 'Country' for generated certificates #1592

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

jbemmel
Copy link
Contributor

@jbemmel jbemmel commented Sep 15, 2023

Some users have reported errors from certain tools when the country is not a valid 2-letter string

Some users have reported errors from certain tools when the country is not a valid 2-letter string
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1592 (df93408) into main (c24ae35) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1592   +/-   ##
=======================================
  Coverage   48.55%   48.55%           
=======================================
  Files         133      133           
  Lines       12778    12779    +1     
=======================================
+ Hits         6204     6205    +1     
  Misses       5870     5870           
  Partials      704      704           
Files Changed Coverage Δ
cmd/deploy.go 65.73% <100.00%> (+0.12%) ⬆️
nodes/default_node.go 56.01% <100.00%> (ø)

@hellt hellt merged commit 2c36cc8 into main Sep 15, 2023
19 checks passed
@hellt hellt deleted the jbemmel-patch-1 branch September 15, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants