Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when no keys present for srl node #1604

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

hellt
Copy link
Member

@hellt hellt commented Sep 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1604 (594f913) into main (f2b4a62) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 73.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
- Coverage   48.59%   48.58%   -0.02%     
==========================================
  Files         133      133              
  Lines       12789    12798       +9     
==========================================
+ Hits         6215     6218       +3     
- Misses       5870     5874       +4     
- Partials      704      706       +2     
Files Changed Coverage Δ
nodes/srl/srl.go 57.07% <0.00%> (ø)
nodes/srl/sshkey.go 88.88% <78.57%> (-11.12%) ⬇️

... and 2 files with indirect coverage changes

@hellt hellt merged commit 9197213 into main Sep 21, 2023
18 of 19 checks passed
@hellt hellt deleted the fix-no-keys-on-0-srl branch September 21, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant