Fixing MacVlan interface provisioning #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in addition a slight reorg of MacVlanMode enum
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1635 +/- ##
==========================================
+ Coverage 50.29% 50.93% +0.63%
==========================================
Files 135 135
Lines 13090 13091 +1
==========================================
+ Hits 6584 6668 +84
+ Misses 5781 5694 -87
- Partials 725 729 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacVlan interfaces are dependent on an existing parent Interface.
This parent interface defines the MTU of the derived MacVlan interface.
This PR now avoids setting the MTU for MacVlan interfaces but instead queries the parent interface in the resolve phase and adjusts the internal MTU value of the MacVlan interface accordingly, such that on configuration generation, this value can be propagated to the nodes config.
Fixing #1633