Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not populate DNS for nodes in netw mode container #1676

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Do not populate DNS for nodes in netw mode container #1676

merged 1 commit into from
Oct 26, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Oct 26, 2023

fix #1673

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1676 (147e1ca) into main (1da5ebd) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
+ Coverage   51.09%   51.31%   +0.22%     
==========================================
  Files         138      138              
  Lines       13349    13354       +5     
==========================================
+ Hits         6821     6853      +32     
+ Misses       5774     5741      -33     
- Partials      754      760       +6     
Files Coverage Δ
clab/clab.go 76.49% <100.00%> (+0.81%) ⬆️

... and 3 files with indirect coverage changes

@hellt hellt merged commit 2d2e67a into main Oct 26, 2023
22 checks passed
@hellt hellt deleted the nil-dns branch October 26, 2023 09:57
Copy link

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! And of course a reproducer smoke test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not use container network-mode
2 participants