Update install.md and improve dev container setup and fix some spelling mistakes. #1689
Conversation
|
Hi @neilschark |
docs/install.md
Outdated
| && apt-get upgrade -y | ||
| apt-get install -y --no-install-recommends \ |
There was a problem hiding this comment.
@neilschark
I wouldn't do the upgrade here, it will take quite some time and will leave you with a different base OS more frequently then package updates.
Not sure it is worth it, but I may be wrong.
What seems to be clearly missing here though is && after upgrade
There was a problem hiding this comment.
I don't think time is a problem here, as the creation of the dev container from scratch depending on the added feature already takes several minutes if you have a slow Internet connection. But after the first building everything is cached, so it doesn't matter anymore, as it is not run again until you pull a clean base image.
I get you second point though, it makes the image possibly different. I don't think it matters much, as for example the docker in docker feature is added with the 'latest' tag, so you will have this problem anyway.
In my experience the base image of debian is updated less enough so that you get some updates in this step regularly. I would guess that the image provided by Microsoft which is the base here is updated even less, so updates with security fixes would likely occur.
But at the and it is not a mayor difference either way, so I would leave it up to the project (and therefore you) to decide.
Just to have it complete I just add the missing '&&' you mentioned. Simply either accept the PR like it is now or tell me to remove the update line, I am fine with it both ways.
Co-authored-by: Roman Dodin <dodin.roman@gmail.com>
…containerlab into neilschark-devcontainer-docs
|
thnx, lets ship it and later down the road we will see if that works for everybody |
Hi,
as I use the dev container setup daily for my work, I made some improvements to make using this setup easier. Some of these changes are specific to my use case, but everything which is a general improvement is added in this PR.
And i fixed some spelling mistakes I found on the way.