Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-vr prefixed kind names #1710

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Added non-vr prefixed kind names #1710

merged 5 commits into from
Nov 12, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Nov 12, 2023

vr-nokia_sros becomes nokia_sros and so on.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #1710 (45e69e1) into main (3c24d9b) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
+ Coverage   51.62%   51.74%   +0.12%     
==========================================
  Files         141      140       -1     
  Lines       13751    13709      -42     
==========================================
- Hits         7099     7094       -5     
+ Misses       5864     5827      -37     
  Partials      788      788              
Files Coverage Δ
clab/register.go 100.00% <ø> (ø)
nodes/vr_aoscx/vr-aoscx.go 2.32% <ø> (ø)
nodes/vr_csr/vr-csr.go 1.85% <ø> (ø)
nodes/vr_ftosv/vr-ftosv.go 2.32% <ø> (ø)
nodes/vr_n9kv/vr-n9kv.go 2.32% <ø> (ø)
nodes/vr_pan/vr-pan.go 2.22% <ø> (ø)
nodes/vr_ros/vr-ros.go 2.38% <ø> (ø)
nodes/vr_sros/vr-sros.go 0.58% <ø> (ø)
nodes/vr_veos/vr-veos.go 1.81% <ø> (ø)
nodes/vr_vjunosswitch/vr-vjunosswitch.go 1.85% <ø> (ø)
... and 5 more

... and 1 file with indirect coverage changes

@hellt hellt merged commit 7c84208 into main Nov 12, 2023
22 checks passed
@hellt hellt deleted the simple-vr-names branch November 12, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant