Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rn-0.48 #1711

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Added rn-0.48 #1711

merged 1 commit into from
Nov 13, 2023

Conversation

hellt
Copy link
Member

@hellt hellt commented Nov 12, 2023 •
edited
Loading

steiler
steiler reviewed Nov 13, 2023
View reviewed changes
docs/rn/0.48.md

## Goodbye `vr-` prefix!

For a very long time we used `vr-<NOS>` kind names to denote the VM-based lab nodes - a naming prefix adopted from vrnetlab project. After we introduced a common naming scheme for kind names `<vendor>-<NOS>` we decided to deprecate the old naming scheme and to remove the `vr-` prefix from the VM-based nodes.
Copy link
Collaborator

@steiler steiler Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vr_<NOS> not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is vr-vendor_nos

@hellt hellt marked this pull request as ready for review November 13, 2023 09:42
@hellt hellt merged commit d8ffead into main Nov 13, 2023
16 checks passed
@hellt hellt deleted the rn-0.48 branch November 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steiler steiler steiler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hellt @steiler