Remove unbound ssh option for older clients #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
commented
Nov 13, 2023
clab/sshconfig.go
Outdated
Comment on lines
74
to
82
|
|
||
| // if we couldn't parse the ssh version we assume we can't use unbound option | ||
| // or if the version is lower than 8.9 | ||
| // and the node has the PubkeyAuthentication set to unbound | ||
| // we set it to empty string since it is not supported by the SSH client | ||
| if (sshVersion == "" || semver.Compare(sshVersion, "8.9") < 0) && nodeData.SSHConfig.PubkeyAuthentication == types.PubkeyAuthValueUnbound { | ||
| nodeData.SSHConfig.PubkeyAuthentication = "" | ||
| } | ||
|
|
There was a problem hiding this comment.
@steiler I am going to merge this one so that people who upgrade won't have to wait long for this crit fix, but if you find a better way to handle this (like grepping ssh version once and storing it centrally) then we can revisit this in a subsequent PR
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
==========================================
+ Coverage 51.51% 51.57% +0.05%
==========================================
Files 142 143 +1
Lines 13776 13807 +31
==========================================
+ Hits 7097 7121 +24
- Misses 5891 5896 +5
- Partials 788 790 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1719