Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a firewall interface #1850

Merged
merged 9 commits into from
Feb 5, 2024
Merged

create a firewall interface #1850

merged 9 commits into from
Feb 5, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jan 31, 2024

This is creating a firewall interface and reintroduce the iptables integration as a fallback.

This is creating a firewall interface and reintroduce the iptables integration as a fallback.
@steiler steiler linked an issue Jan 31, 2024 that may be closed by this pull request
@steiler steiler requested a review from hellt January 31, 2024 14:38
@steiler steiler marked this pull request as ready for review January 31, 2024 15:38
go.mod Outdated Show resolved Hide resolved
@steiler
Copy link
Collaborator Author

steiler commented Feb 5, 2024

This is ready for you to review / merge now @hellt.

@hellt
Copy link
Member

hellt commented Feb 5, 2024

Thanks @steiler
LGTM, just added some comments to exported funcs

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 147 lines in your changes are missing coverage. Please review.

Comparison is base (30dfa30) 51.82% compared to head (addc92b) 51.59%.
Report is 8 commits behind head on main.

❗ Current head addc92b differs from pull request most recent head 6abd0e7. Consider uploading reports for the commit 6abd0e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
- Coverage   51.82%   51.59%   -0.23%     
==========================================
  Files         148      152       +4     
  Lines       14548    14634      +86     
==========================================
+ Hits         7539     7550      +11     
- Misses       6176     6249      +73     
- Partials      833      835       +2     
Files Coverage Δ
runtime/docker/firewall/firewall.go 54.54% <54.54%> (ø)
runtime/docker/firewall/nftables/rule.go 83.01% <83.01%> (ø)
runtime/docker/firewall.go 33.33% <33.33%> (ø)
runtime/docker/firewall/nftables/client.go 70.73% <70.73%> (ø)
runtime/docker/firewall/iptables/client.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@hellt hellt merged commit f23ddd9 into main Feb 5, 2024
55 checks passed
@hellt hellt deleted the firewallinterface branch February 5, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable firewall rule engine
2 participants