Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unnessecary and even wrong error log #1892

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fixing unnessecary and even wrong error log #1892

merged 2 commits into from
Feb 16, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Feb 16, 2024

On the call to MustWait on the dependency manager node, with a given stage, a non existing stage entry triggered an error log. However the non existence must simply be reflected by a false value. No Wait needs to happen.

@steiler steiler marked this pull request as ready for review February 16, 2024 09:37
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (49fd647) 53.64% compared to head (3bf8cc1) 53.61%.

❗ Current head 3bf8cc1 differs from pull request most recent head 9f4f08b. Consider uploading reports for the commit 9f4f08b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
- Coverage   53.64%   53.61%   -0.04%     
==========================================
  Files         154      154              
  Lines       11236    11227       -9     
==========================================
- Hits         6028     6019       -9     
  Misses       4347     4347              
  Partials      861      861              
Files Coverage Δ
clab/dependency_manager/dependency_node.go 95.55% <100.00%> (ø)
clab/clab.go 75.16% <66.66%> (-0.50%) ⬇️

@hellt hellt merged commit aaeb64b into main Feb 16, 2024
5 of 6 checks passed
@hellt hellt deleted the fixstageerror branch February 16, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants