Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network-Mode fix #1940

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Network-Mode fix #1940

merged 3 commits into from
Mar 13, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Mar 13, 2024

Closes #1939

re-introducing the continue statement for network-namespace sharing, when the referenced namespace is considered an external container. This got messed up via fff2a54#diff-831ecb8143ceda28e72434a64e3b7f88d15f9492071603608fd0180ae3105e67L440-L444

@steiler steiler marked this pull request as ready for review March 13, 2024 10:27
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.66%. Comparing base (e269a28) to head (e3a2171).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
+ Coverage   53.53%   53.66%   +0.12%     
==========================================
  Files         155      155              
  Lines       11347    11348       +1     
==========================================
+ Hits         6075     6090      +15     
+ Misses       4413     4403      -10     
+ Partials      859      855       -4     
Files Coverage Δ
clab/clab.go 75.73% <100.00%> (+0.50%) ⬆️

... and 2 files with indirect coverage changes

@hellt
Copy link
Member

hellt commented Mar 13, 2024

ship it @steiler

@steiler steiler merged commit 1042e22 into main Mar 13, 2024
62 checks passed
@steiler steiler deleted the networkmodefix branch March 13, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

containerlab deploy panics when sharing namespace with an existing container created by kind
2 participants