Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version based checks and add x3/x1 platforms #1943

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix version based checks and add x3/x1 platforms #1943

merged 2 commits into from
Mar 18, 2024

Conversation

hellt
Copy link
Member

@hellt hellt commented Mar 14, 2024

No description provided.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.89%. Comparing base (756d51a) to head (d1c7f51).
Report is 6 commits behind head on main.

❗ Current head d1c7f51 differs from pull request most recent head c72076a. Consider uploading reports for the commit c72076a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
- Coverage   53.90%   53.89%   -0.02%     
==========================================
  Files         156      156              
  Lines       11382    11386       +4     
==========================================
+ Hits         6135     6136       +1     
- Misses       4387     4390       +3     
  Partials      860      860              
Files Coverage Δ
nodes/srl/srl.go 58.51% <100.00%> (+0.11%) ⬆️
nodes/srl/version.go 92.30% <100.00%> (+9.69%) ⬆️

... and 1 file with indirect coverage changes

@hellt hellt marked this pull request as ready for review March 18, 2024 21:57
@hellt hellt merged commit ffba2c4 into main Mar 18, 2024
60 checks passed
@hellt hellt deleted the srl-ixr13b branch March 18, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant