add cookie consent and option to manage cookies #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope, I can also win the most weird cLab PR crown by opening that. 😃 |
|
I wonder why squidfunk doesn't have this on https://squidfunk.github.io/mkdocs-material/ But yeah, it is better to be safe, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerlab MkDocs is using Google Analytics, which is not necessarily GDPR compliant. While this goes against engineering common sense and is very theoretical concern - you never know if it will hit or not. Legal world is weird. I'd suggest at least adding an explicit cookie consent and an option to change cookie settings as it's documented in MkDocs privacy section.
GDPR and Google Analytics is a long read that can certainly not be covered in a single PR.
To add more fun, German court decided Jan 2022, that Google Fonts are not GDPR compliant as well. There is a MkDocs knob for that (privacy plugin): squidfunk/mkdocs-material#739
However I'll not add it as part of this PR as it looks a bit theoretical to me and every MkDocs site is using gFonts anyway.
I believe that Containerlab community is sane and have nothing to worry about, but as it's also quite popular - some basic guards may be helpful.