Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetNSPath for ignite #2000

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Fix GetNSPath for ignite #2000

merged 2 commits into from
Apr 19, 2024

Conversation

robertvolkmann
Copy link
Contributor

@robertvolkmann robertvolkmann commented Apr 18, 2024

Containerlab is unable to find the network namespace path using ignite runtime since 0.53.0.

INFO[0001] Networking is handled by "docker-bridge"     
INFO[0001] Started Firecracker VM "5166f4a61292d357" in a container with ID "aad296f2246e7022153a54462c890b8d955218ee8e0501cdf3277b618a879f5c" 
ERRO[0001] Unable to determine NetNS Path for node leaf02: Error response from daemon: No such container: leaf02 
ERRO[0001] failed deploy links for node "leaf02": Error response from daemon: No such container: leaf02 
INFO[0003] Networking is handled by "docker-bridge"     
INFO[0003] Started Firecracker VM "b92c63db14bfbfad" in a container with ID "1c2d5a8b21c99d35a553eaa3c0cffbfee007e4940b8b71ea23ce848d6deaf7f9" 
ERRO[0003] Unable to determine NetNS Path for node leaf01: Error response from daemon: No such container: leaf01 
ERRO[0003] failed deploy links for node "leaf01": Error response from daemon: No such container: leaf01 

Before the refactoring, the ns path was saved in the configuration of the node. Now it is retrieved from the runtime using the LongName, which is the name of the ignite VM.

See: https://github.com/srl-labs/containerlab/pull/1906/files#diff-d25cfdb9022b8a280a3cf87aa5a83926d393e4d5d28c550dd57cca87c9130359R169

Caused by #1906

robertvolkmann and others added 2 commits April 18, 2024 17:38
GetNSPath is called with the VM name
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 53.59%. Comparing base (f2b4a62) to head (5b9cafd).
Report is 284 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
+ Coverage   48.59%   53.59%   +5.00%     
==========================================
  Files         133      160      +27     
  Lines       12789    11536    -1253     
==========================================
- Hits         6215     6183      -32     
+ Misses       5870     4488    -1382     
- Partials      704      865     +161     
Files Coverage Δ
runtime/ignite/ignite.go 0.40% <0.00%> (+0.09%) ⬆️

... and 125 files with indirect coverage changes

@hellt hellt merged commit 0c587c8 into srl-labs:main Apr 19, 2024
63 checks passed
@hellt
Copy link
Member

hellt commented Apr 19, 2024

thanks @robertvolkmann !

@robertvolkmann robertvolkmann deleted the fix-ignite branch April 19, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants