refactored type init #203
refactored type init #203
Conversation
clab/config.go
Outdated
| // default type if not defined | ||
| switch nodeCfg.Kind { | ||
| case "srl": | ||
| return "ixr6" |
There was a problem hiding this comment.
This should maybe not be a hardcoded value but rather reference the srlTypes map.
My approach considered the first key in the map.
case "srl":
for k = range srlTypes {
return k
}
There was a problem hiding this comment.
I dont think its a good idea. The map might be shuffled by someone without noticing that its values are used in something like default type
There was a problem hiding this comment.
I just do not like arbitrary strings that much. I'd rather opt for an enum kind of type.
If someone messes with that string it breaks and if ixr6 is entirely removed from the list there is inconsistency as well.
But ok.
There was a problem hiding this comment.
I made it a constant, so that this will be visible better 53c7b4c
There was a problem hiding this comment.
btw, range over dict will yield inconsistent results, as map access is random https://repl.it/@RomanDodin/EnragedSlightSpool
close #199