align srl config template with 20.6.3 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The template is not static nor it is part of the code, nothing stops a user from replacing it with a another one they prefer. |
|
Yes, but that wasn't my point.
I wonder if it's possible to make Srl apply portions of config on top of a
default one.
The post deploy actions can be used for that, but I'd rather explore Srl
capabilities first
…On Tue, 12 Jan 2021, 23:57 Karim Radhouani, ***@***.***> wrote:
The template is not static nor it is part of the code, nothing stops a
user from replacing it with a another one they prefer.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#228 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLKV5I55YUFYJ4TXTCVVNLSZTHXJANCNFSM4V7YUI2Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its not particularly great that we have some static template carried within the code for srlinux. When new features are added we must ensure that the CPM filters are added for those (if needed).
This was the case with OSPF now
It would be nice to think if there is a way to enable gnmi server, tls and lldp (these are the changes that containerlab adds on top of a default config) in addition to the config
/cc @karimra