-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --keep-mgmt-net for destroy subcmd #462
Conversation
Alright then, I'd consider this done now. |
Resolved merge conflicts. |
I think it is time to add a test for this case |
@hellt are you fine with the tests |
@steiler can you please also add a doc entry about this flag of |
@steiler also I think you wanted to add the schema entry for bridge under |
@hellt That is not related to this flag, so it should go into a new PR. |
Since we've gone downa different path now, with karims work on refactoring the runtime interface, should the withKeepMgmtNet() func now be replaced by jsut the field in the withConfig piece? |
can you create a commit with that approach? Looks more clean to me |
As discussed, we go with this approach for now and tackle a potential change in a different PR. |
Implementing #271.
This is based upon changes introduced in #460.
At the same time it adds an implementation of the DeleteNet() for containerd.
Here we are listing all the Host interfaces to see if the bridge is still the master to any existing device, if not, and not --keep-mgmt-net is set, the deletion of the cni based mgmt bridge is executed.