Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing containerd filters #481

Merged
merged 5 commits into from
Jun 30, 2021
Merged

fixing containerd filters #481

merged 5 commits into from
Jun 30, 2021

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Jun 28, 2021

adding additional escaping and fixing the filter string building

@steiler
Copy link
Collaborator Author

steiler commented Jun 30, 2021

Swapped in your cut orgy for a perl regex. ;-)
Now interface index is properly matched and can be found on the host.

@hellt
Copy link
Member

hellt commented Jun 30, 2021

not ever in my wildest nightmares I had a line of perl code in the projects I take part in 🤣

but thanks a lot, lets do this, maybe I will swap it later for regex-flavored grep

@hellt hellt merged commit a7a8033 into master Jun 30, 2021
@hellt
Copy link
Member

hellt commented Jun 30, 2021

I guess you also need to close that issue in containerd repo?

@hellt hellt deleted the containerdexecfilterfix branch June 29, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants