making sure scrapli cleanup doesnt break things! #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
howdy folks!
@hellt is already in the loop on some of this, but for anyone else interested -- I've been doing a bit of housekeeping on scrapligo things and made some breaking-ish changes; this draft (until I finalize things ive been working on) is pinned to a dev branch and contains the little fixes that will be necessary if ya'll want to update the scrapligo pin. I think I should be fairly close to being done changing/breaking things and I will update this branch w/ pin to master branch (or perhaps even a real release finally) once I get to that point.
Carl