Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To address Issues 18 and 19 #21

Merged
merged 9 commits into from
Feb 27, 2024
Merged

To address Issues 18 and 19 #21

merged 9 commits into from
Feb 27, 2024

Conversation

tiago-amado
Copy link
Collaborator

@tiago-amado tiago-amado commented Feb 26, 2024

Closes #19 - use a single bash script for the automation node #19
Closes #18 - create requirements.txt for python deps #18

use a single bash script for the automation node #19 and
create requirements.txt for python deps #18
Copy link
Collaborator Author

@tiago-amado tiago-amado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address the issues #18 and #19

@tiago-amado tiago-amado changed the title Issues: To address Issues 18 and 19 Feb 26, 2024
@@ -31,19 +30,18 @@ apk add python3-dev
apk add musl-dev
apk add libffi-dev
/venv/bin/python3 -m pip install --upgrade pip
pip install pygnmi
pip install flask
pip install -r /config/requirements.txt
#pip install pygnmi
#pip install gunicorn
#python -m flask --version
#apt-get install gunicorn
#flask run &
flask run --host=0.0.0.0 &
sleep 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sleep is likely not needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sleep it self is not needed. it has been added because the flask running in backgroud ( by the "&" at the end of the line) and at that echo whould be executed right after. the sleep is to create a 5 seconds delay between the command send 'flask run --host=0.0.0.0 &' and the command send 'echo "END Flask and Python installation script execution!"'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use a single bash script for the automation node create requirements.txt for python deps
3 participants