Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full class/method names, max-width based column output, etc #2

Merged
merged 5 commits into from Apr 2, 2012

Conversation

daf
Copy link
Contributor

@daf daf commented Apr 2, 2012

Using the inspect module, we pull out any self method vars in a call and record that, and then resolve which class actually defines that method via line number.

It changes the behavior slightly, in that overrides in the same module are no longer grouped together, but I found it much easier to understand, especially in summary view. The combination (as was the old behavior) is somewhat useful for stats view, but I still prefer this one.

As a result, the output is longer and less predictable, so I calculate the maximum width of each column and only output what is needed.

Also the .pyc file is removed.

srlindsay added a commit that referenced this pull request Apr 2, 2012
Full class/method names, max-width based column output, etc
@srlindsay srlindsay merged commit e8f1951 into srlindsay:master Apr 2, 2012
@srlindsay
Copy link
Owner

This is much better than what I was doing. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants