Use Throwable instead of XxxExceptions classes #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Throwable instead of handling multiple types of Exception classes repeatedly
srmklive
reviewed
Jan 30, 2020
No problem, all done. I can look at potentially replacing all Catches with Throwable in case of PHP update which causes more Errors/Exceptions if you fancy it? |
|
Sure go ahead |
- Catch Throwable where possible - Convert all thrown Exceptions to RuntimeExceptions - Convert anonymous functions to static anonymous functions (speed improvement in some cases) - Split some complex workflows into separate chunks to return early - Use 'use' statements where possible to avoid having \Unnecessary\Qualifiers\Everywhere - Use strict type checking where possible - Remove some unnecessary brackets from some clauses - No longer use !is_null() function just use !== null instead
|
I'm afraid that I'm not sure what styleci is complaining about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Throwable instead of handling multiple types of Exception classes repeatedly