Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script for use by the IDE #87

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Add a script for use by the IDE #87

merged 1 commit into from
Jun 13, 2020

Conversation

PeterJCLaw
Copy link
Member

@PeterJCLaw PeterJCLaw commented May 31, 2020

Contributes to #86.

I've tested locally that this works with an IDE instance.

@PeterJCLaw
Copy link
Member Author

I've also tested the linting side of things with a Python3 venv for pylint; that worked fine.

These are the corresponding IDE settings to make this export work and to use this repo's implementation as the lint reference:

pylint.reference_dir = /path/to/competition-simulator/controllers/sr_controller
lib_robot.dir = /path/to/competition-simulator
lib_robot.archive_script = script/create-ide-archive

@antoinepetty
Copy link
Member

I'm not sure how to review this

@trickeydan
Copy link
Contributor

I'm not sure how to review this

Nor am I. We probably need somebody familiar with the IDE, so possibly @prophile ?

@PeterJCLaw
Copy link
Member Author

You could check that it works with a local IDE instance if you like?
The IDE setup instructions in its README should cover you on that side, aside from that all that should be needed is the configuration settings included in my previous comment.

Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally and the robot.zip outputs in the format I expect, and the code check seems to run without issue (I've not fully regressed what the linter picks up, but it does run).

@PeterJCLaw PeterJCLaw merged commit 7acc3b2 into master Jun 13, 2020
@PeterJCLaw PeterJCLaw deleted the ide-support branch June 13, 2020 18:42
@PeterJCLaw PeterJCLaw mentioned this pull request Jun 13, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants