This repository has been archived by the owner on Jan 25, 2024. It is now read-only.
Add minimal board definition for Arduino Uno #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierdavis
reviewed
May 19, 2019
kierdavis
reviewed
May 31, 2019
sedders123
reviewed
May 31, 2019
|
I've done a rebase to clean up the history here, but it should be good to go now. |
trickeydan
requested review from
kierdavis and
sedders123
and removed request for
kierdavis
Fix misordered arguments in cast. Looks like I was quite tired when I wrote that originally.. Remove setup_arduino function
|
Code Climate has analyzed commit 58f7aaf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 98.5% (0.0% change). View more on Code Climate. |
kierdavis
approved these changes
Jun 6, 2019
sedders123
approved these changes
Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful as the parent class for #66 and #65
Missing from this board definition:
These are not in scope for this. This PR only implements what is necessary for #65 and #66. Issues should be added to implement this support in the future.