Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit that places aren't guaranteed #103

Merged
merged 1 commit into from Oct 5, 2018

Conversation

RealOrangeOne
Copy link
Member

It's unlikely we'll need to prevent teams from completing, but we should still account for it!

It's unlikely we'll need to prevent teams from completing, but we should still account for it!
@RealOrangeOne RealOrangeOne requested review from PeterJCLaw and a user October 1, 2018 08:02
Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, though I think we should also update the compete page (/compete.html).

@RealOrangeOne
Copy link
Member Author

@PeterJCLaw I don't see this copy on the complete screen, nor anything like it which pertains to the fact places aren't 100% confirmed.

@PeterJCLaw
Copy link
Member

Ah, I was thinking of the line:

Entries for this year's competition are open until the 26th October 2018.

though you're right that that is already framed differently than this was.

@jimmythompson
Copy link
Member

Can you elaborate a little bit on what happens if you'd like to enter multiple teams?

@RealOrangeOne
Copy link
Member Author

@jimmythompson currently it's just stored in MailChimp. When it comes to selection, I'd argue we try and fit all teams who requested a place in as we can. If we have the ability to allow more places, then we should allocate second teams on 'first come, first served'

@PeterJCLaw
Copy link
Member

@RealOrangeOne I think that @jimmythompson meant: could we change the wording to be a bit more explicit about what happens if one wants to enter multiple teams.

@RealOrangeOne RealOrangeOne merged commit 1448b72 into master Oct 5, 2018
@RealOrangeOne RealOrangeOne deleted the non-confirmed-places branch October 5, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants