Competition 2019 details #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyler-Ward
previously requested changes
Mar 2, 2019
There was a problem hiding this comment.
The parking information is wrong see srobo/tasks#193 for correct map.
|
@Tyler-Ward (and everyone else) What are your thoughts on embedding the map image into the page? I am liking the current layout but can understand if you want links only. Also, are you expecting the "last mile" info in order to ship this? |
PeterJCLaw
requested changes
Mar 2, 2019
Co-Authored-By: antoinepetty <36314396+antoinepetty@users.noreply.github.com>
…ebsite into competition-2019-details
Ah yes, my mistake. |
RealOrangeOne
previously approved these changes
Mar 5, 2019
PeterJCLaw
reviewed
Mar 6, 2019
PeterJCLaw
reviewed
Mar 6, 2019
PeterJCLaw
reviewed
Mar 6, 2019
Co-Authored-By: antoinepetty <36314396+antoinepetty@users.noreply.github.com>
…ebsite into competition-2019-details
antoinepetty
dismissed
Tyler-Ward’s stale review
New parking map added to event page
|
Should be ready to deploy now |
PeterJCLaw
previously approved these changes
Mar 6, 2019
PeterJCLaw
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the confirmed details and elaborating more on the competition event page.