Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set 0 as a value of env var #5

Closed
bocharsky-bw opened this issue Feb 5, 2018 · 6 comments · Fixed by #6
Closed

Unable to set 0 as a value of env var #5

bocharsky-bw opened this issue Feb 5, 2018 · 6 comments · Fixed by #6

Comments

@bocharsky-bw
Copy link

How can I set false as a value of environment variable? Before, I handled it with 0 value which was converted to false with %env(bool:BOOL_ENV_VAR)% Symfony feature. But now, when I set 0 during interactive mode of ./vendor/bin/companienv it just re-ask a new value.

@sroze
Copy link
Owner

sroze commented Feb 5, 2018

Hi @bocharsky-bw! Thank you for your feedback. You are right, and I've issued the pull-request #6 to fix this problem. Would you like to review it?

@sroze sroze closed this as completed in #6 Feb 6, 2018
@sroze
Copy link
Owner

sroze commented Feb 6, 2018

This has been fixed and released as part of 0.0.5.

@bocharsky-bw
Copy link
Author

Hey @sroze ,

Thanks for the quick fix! Now it better, when I have ENV_VAR=0 in .env file - it does not tell me "It looks like you are missing some configuration (1 variables)" message anymore, but I still can't set up 0 through interactive mode, i.e. when I have ENV_VAR= in .env file and run ./vendor/bin/companienv - still can't put 0, see screenshot:

screen shot 2018-02-06 at 12 37 15

@sroze
Copy link
Owner

sroze commented Feb 6, 2018

@bocharsky-bw here we go: #9. Could you give a try and let me know if there is anything else? 🤔

@sroze
Copy link
Owner

sroze commented Feb 6, 2018

The PR #9 has been released in 0.0.6

@bocharsky-bw
Copy link
Author

Works for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants