Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and workflows #4

Closed
Nelson-Gon opened this issue Apr 12, 2021 · 1 comment
Closed

Tests and workflows #4

Nelson-Gon opened this issue Apr 12, 2021 · 1 comment

Comments

@Nelson-Gon
Copy link
Contributor

Hello,

I was wondering what you think of adding tests to ensure that things work as expected and also GitHub actions to check for such things as working installs, imports, or tests.

Thank you,

Nelson

@Nelson-Gon Nelson-Gon changed the title Testis and workflows Tests and workflows Apr 12, 2021
@srush
Copy link
Owner

srush commented Apr 12, 2021

Sounds great. I normally do automated linting and pytest like this file

https://github.com/harvardnlp/pytorch-struct/blob/master/.github/workflows/torch-struct.yml

If you want to adapt something like that I would love a PR.

Nelson-Gon added a commit to Nelson-Gon/streambook that referenced this issue Apr 13, 2021
@srush srush closed this as completed Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants