-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor all the things #16
Conversation
also show completions if cusror is in function call
|
||
def completions_from_script(self, script, insert_params): | ||
"regular completions" | ||
completions = self.filter_completions(script.complete()) or [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm bit misunderstand. Why we need this? Can you show some examples ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well filter function is to get rid of duplicates like os.path
im aware that jedi has a setting for that but somehow it didnt worked for me. dunno why.
as for or []
it sneaked in on refactoring :) I'll remove that
Hi! |
done |
Any chance of a sublime text 3 reshuffle while your at it? |
personally I dont have sublime 3 and im not going to upgrade for some time |
Fair enough. |
that one is a nice merge technique :-) |
Yeah, I'll never use github tips more :) (or will use them more carefully) |
I think that commit log shows whats have been done but if you have any questions dont hesitate to ask.
few things to note:
auto_complete_function_params
to settings so user can decide whether plugin should insert function's aruments on completion. one thing to think about is whether we would like to insert required arguments even if that param is turned off