Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor all the things #16

Closed
wants to merge 14 commits into from
Closed

refactor all the things #16

wants to merge 14 commits into from

Conversation

krya
Copy link
Contributor

@krya krya commented Mar 17, 2013

I think that commit log shows whats have been done but if you have any questions dont hesitate to ask.
few things to note:

  • changed current calltip info to have just name and its type so it wont scare people :-)
  • added an auto_complete_function_params to settings so user can decide whether plugin should insert function's aruments on completion. one thing to think about is whether we would like to insert required arguments even if that param is turned off
  • now pluging doesnt crash on unsaved buffer and does not open an empty buffer on goto if module is a builtin one.


def completions_from_script(self, script, insert_params):
"regular completions"
completions = self.filter_completions(script.complete()) or []
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm bit misunderstand. Why we need this? Can you show some examples ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well filter function is to get rid of duplicates like os.path im aware that jedi has a setting for that but somehow it didnt worked for me. dunno why.
as for or [] it sneaked in on refactoring :) I'll remove that

@srusskih
Copy link
Owner

Hi!
Great job!
One more request :)
Can you replace "-comments to """-comments ? :)

@krya
Copy link
Contributor Author

krya commented Mar 17, 2013

done

@nfaggian
Copy link

Any chance of a sublime text 3 reshuffle while your at it?

@krya
Copy link
Contributor Author

krya commented Mar 17, 2013

personally I dont have sublime 3 and im not going to upgrade for some time

@nfaggian
Copy link

Fair enough.

@srusskih
Copy link
Owner

Descriptions missed

Screenshot - 03182013 - 09:28:03 AM

settings:

{
    "folders":
    [
        {
            "path": "/storage/PythonProjects/SublimeJEDI"
        }
    ]
}

system python: Python 2.7.3
OS: Ubuntu 12.10

@srusskih srusskih mentioned this pull request Mar 18, 2013
@srusskih
Copy link
Owner

febdd68

@srusskih srusskih closed this Mar 22, 2013
@krya
Copy link
Contributor Author

krya commented Mar 25, 2013

that one is a nice merge technique :-)

@srusskih
Copy link
Owner

Yeah, I'll never use github tips more :) (or will use them more carefully)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants