Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getssl forkbombs if folder not writeable #440

Closed
Londran opened this issue Oct 18, 2019 · 0 comments · Fixed by #581
Closed

Getssl forkbombs if folder not writeable #440

Londran opened this issue Oct 18, 2019 · 0 comments · Fixed by #581
Assignees
@timkimber
Labels
bug help wanted
Projects
bugfix

Comments

@Londran
Copy link

Londran commented Oct 18, 2019

Getssl acts like a forkbomb (though a slow one) if the folder containing the script is not writeable by the executing user trying to update said script.

Killed my server once. Maybe a quick check (is folder writable) or ulimit directives before it tries to update might resolve that. I just do not know if this is doable for alle platforms though.

I hardened my shell with:
ulimit -u 10
ulimit -t 10

BR,
Londran.
@QuingKhaos QuingKhaos added this to Needs triage in bugfix via automation Oct 19, 2019
@timkimber timkimber self-assigned this Feb 27, 2020
@srvrco srvrco deleted a comment from github-actions bot Feb 27, 2020
wurtel2 pushed a commit to wurtel2/getssl that referenced this issue Aug 31, 2020
Fix slow fork bomb when directory containing getssl isn't writeable (s…
68b05d7 
…rvrco#440)

getssl updets itself by:
- checking for a new version
- if so:
  - download the new one into a tmp location
  - rename the current one to name with version appended
  - rename the tmp file to the current location
  - run the new version
If the renaming fails, the old version gets run, which again downloads, etc.
Now exit if the rename (install command) fails.
@wurtel2 wurtel2 mentioned this issue Aug 31, 2020
Merged
@timkimber timkimber linked a pull request Sep 3, 2020 that will close this issue
Fix slow fork bomb when directory containing getssl isn't writeable (… #581
Merged
bugfix automation moved this from Needs triage to Closed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timkimber timkimber

Labels
bug help wanted
Projects
bugfix
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix slow fork bomb when directory containing getssl isn't writeable (… wurtel2/getssl
3 participants
@QuingKhaos @Londran @timkimber