Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape ` #111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gh-act
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@
-e 's/\\u003D/=/g' \
-e 's/\\u003E/>/g' \
-e 's/\\/\\\\/g' \
-e 's/\\"/\\\\\"/g'
-e 's/\\"/\\\\\"/g' \
-e 's/`/\\`/g'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Expressions don't expand in single quotes, use double quotes for that. SC2016

}

function is_valid_user {
Expand Down Expand Up @@ -449,7 +450,7 @@
BEFORE=$(gh pr view "${PULL_REQUEST_SPEC}" --json commits --jq .commits[].oid | tail -2 | head -1)
# shellcheck disable=SC2046
read -r HEAD HEAD_USER <<< $(gh pr view "${PULL_REQUEST_SPEC}" --json commits \
--template '{{- $last := 0}}

Check warning on line 453 in gh-act

View workflow job for this annotation

GitHub Actions / shellcheck

[shellcheck] reported by reviewdog 🐶 Expressions don't expand in single quotes, use double quotes for that. [SC2016](https://github.com/koalaman/shellcheck/wiki/SC2016) Raw Output: ./gh-act:453:20:info:Expressions don't expand in single quotes, use double quotes for that. [SC2016](https://github.com/koalaman/shellcheck/wiki/SC2016)
{{- range $index, $element := .commits}}{{$last = $index}}{{end}}
{{- $commit := index .commits $last}}
{{- $author := index $commit.authors 0}}
Expand Down
Loading